Merged
Conversation
Updates outdated README file.
aufdenkampe
approved these changes
Apr 3, 2024
Member
aufdenkampe
left a comment
aufdenkampe
left a comment
There was a problem hiding this comment.
Looks great to me! Thanks for making these changes.
Member
|
@kieranbartels, I'm bypassing the precommit action that is failing (https://github.com/LimnoTech/Xarray-DataAccessor/actions/runs/8539975109/job/23395963109?pr=2), because it also appears to be failing on the main branch. It seems the issue is with I think it makes sense to disable the precommit for now, given that we're not actively developing any new capabilities but only working on documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates outdated README file based on initial experience running the gssha_demo.ipynb notebook.